fix(config): default TypeORM synchronize to false across all environments - #1369
Merged
RUKAYAT-CODER merged 1 commit intoAug 29, 2026
Conversation
…ents - Default TypeORM synchronize to false in database.config.ts for all environments - Support explicit opt-in via DATABASE_SYNCHRONIZE / TYPEORM_SYNCHRONIZE env flags - Add DATABASE_SYNCHRONIZE and TYPEORM_SYNCHRONIZE to Joi envValidationSchema - Add comprehensive unit tests in database.config.spec.ts and env.validation.spec.ts - Update documentation and .env.example to reflect migration-driven schema management Closes rinafcode#1210
|
@xeexco Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Defaults TypeORM
synchronizetofalseacross all environments to prevent schema synchronization from fighting migration-managed schemas and dropping columns, while allowing an explicit dev-only opt-in viaDATABASE_SYNCHRONIZEorTYPEORM_SYNCHRONIZE.Related Issue
Closes #1210
Changes
Database Configuration & Validation
src/config/database.config.tssynchronizetofalseacross all environments (production,development,test,ci, or unset).resolveSynchronize()helper allowing explicit opt-in viaDATABASE_SYNCHRONIZE=true|1orTYPEORM_SYNCHRONIZE=true|1.src/config/env.validation.tsDATABASE_SYNCHRONIZEandTYPEORM_SYNCHRONIZEoptional boolean properties toenvValidationSchema.src/config/database.config.spec.tssynchronize: falseacross allNODE_ENVvalues and explicit opt-in via env flags.src/config/env.validation.spec.tsDATABASE_SYNCHRONIZEvalidation and updates valid test environment fixture..env.exampleDATABASE_SYNCHRONIZE=falseunder database configuration.Documentation
docs/migrations.mdsynchronize: falsedefault across environments.docs/setup.md,docs/troubleshooting.md,docs/runbook.mdpnpm migrate:runinstead of auto-synchronize.Verification Results
synchronizetofalsein non-production environmentsdatabase.config.ts& unit testsDATABASE_SYNCHRONIZE)DATABASE_SYNCHRONIZEto env validation schemaenv.validation.ts& specdocs/migrations.md,setup.md,troubleshooting.md,runbook.md,.env.example